Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control: Fall back to old naming if ELD device name decoding fails #234

Conversation

berolinux
Copy link

If ELD device name lookup fails, fall back to the old style naming
instead of disabling the HDMI output altogether.

Fixes: #233
Signed-off-by: Bernhard Rosenkränzer [email protected]

If ELD device name lookup fails, fall back to the old style naming
instead of disabling the HDMI output altogether.

Fixes: alsa-project#233
Signed-off-by: Bernhard Rosenkränzer <[email protected]>
@perexg
Copy link
Member

perexg commented Jun 5, 2022

Thanks for the patch. I would print the error message in __snd_pcm_info_eld_fixup() and return zero instead -EIO for the out-of-range values.

@perexg perexg closed this in 89ee619 Jun 6, 2022
@perexg
Copy link
Member

perexg commented Jun 6, 2022

Fixed a bit differently in 89ee619 . Thank you for the report and proposed fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New device naming breaks HDMI audio if ELD lookup fails
2 participants