Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commmunity/glm: Fixed constexpr with GCC #6742

Closed
wants to merge 1 commit into from

Conversation

mksully22
Copy link
Contributor

community/gource and community/logstalgia fail to build, generating errors of type:
/usr/include/glm/detail/type_vec2.hpp:90:40: error: 'constexpr const T& glm::vec<2, T, Q>::operator[](glm::vec<2, T, Q>::GLM_FUNC_DECL GLM_CONSTEXPR T const& operator[](length_type i) const;

As discussed in glm issue: g-truc/glm#832
a fix has been committed into glm master branch: g-truc/glm@68c7e7e

Until glm version 0.9.9.4 is released this patch can be backported onto 0.9.9.3 to allow gource and logstaligia packages to build.

@andypost andypost requested a review from ncopa March 19, 2019 21:32
@andypost andypost added A-fix Fixes an abuild A-improve Improves an abuild labels Mar 19, 2019
@Ikke
Copy link
Contributor

Ikke commented Mar 20, 2019

For the record, g-truc/glm@68c7e7e seems to be the commit that breaks it, and the included patch reverts that commit

@Ikke
Copy link
Contributor

Ikke commented Apr 2, 2019

Patch didn't apply because the project uses crlf as line ending. I used unix2dos on the patch, and added patch_args="--binary -p1"

@algitbot
Copy link

algitbot commented Apr 2, 2019

Merged in f7a8723 by @Ikke. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Apr 2, 2019
@mksully22 mksully22 deleted the glm branch May 13, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-fix Fixes an abuild A-improve Improves an abuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants