Skip to content

feat(x-for): dispatch change event when x-for create option element #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ljk0071 wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −1
Open

feat(x-for): dispatch change event when x-for create option element #4715

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
233683d
feat(x-for): dispatch change event when x-for create option element
Crepe0071 Dec 21, 2025
372aaf8
fix(x-for): prevent change event dispatch when x-model value exists i…
ljk0071 Dec 22, 2025
5ffc92d
feat(x-for): auto-match select option to x-model value
Crepe0071 Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/alpinejs/src/directives.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { onAttributeRemoved, onElRemoved } from './mutation'
import { onAttributeRemoved } from './mutation'
import { evaluate, evaluateLater } from './evaluator'
import { elementBoundEffect } from './reactivity'
import { nextTick } from "./nextTick";
import Alpine from './alpine'

let prefixAsString = 'x-'
Expand Down Expand Up @@ -65,6 +66,19 @@ export function directives(el, attributes, originalAttributeOverride) {
.map(toParsedDirectives(transformedAttributeMap, originalAttributeOverride))
.sort(byPriority)

if (el.tagName.toLowerCase() === 'option') {
nextTick(() => {
const modelName = el.parentNode.getAttribute('x-model');
if (modelName) {
const currentValue = evaluate(el.parentNode, modelName);
const values = Array.from(el.parentNode.options).map(opt => opt.value);

if (!values.includes(currentValue)) el.parentNode.dispatchEvent(new Event('change', {bubbles: true}))
else if (el.parentNode.value !== currentValue) el.parentNode.value = currentValue
}
});
}

return directives.map(directive => {
return getDirectiveHandler(el, directive)
})
Expand Down