Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ jobs:
- run: npm install
- run: npm run build
- run: npm run test
- run: npm run vitest
6,966 changes: 4,560 additions & 2,406 deletions package-lock.json

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@
"dot-json": "^1.2.2",
"esbuild": "~0.16.17",
"jest": "^26.6.3",
"sortablejs": "^1.15.2"
"sortablejs": "^1.15.2",
"vitest": "^3.2.4"
},
"scripts": {
"build": "node ./scripts/build.js",
"watch": "node ./scripts/build.js --watch",
"test": "cypress run --quiet",
"cypress": "cypress open",
"jest": "jest test",
"vitest": "vitest run",
"update-docs": "node ./scripts/update-docs.js",
"release": "node ./scripts/release.js"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/alpinejs/src/evaluator.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { closestDataStack, mergeProxies } from './scope'
import { injectMagics } from './magics'
import { tryCatch, handleError } from './utils/error'

let shouldAutoEvaluateFunctions = true
export let shouldAutoEvaluateFunctions = true

export function dontAutoEvaluateFunctions(callback) {
let cache = shouldAutoEvaluateFunctions
Expand Down
41 changes: 17 additions & 24 deletions packages/csp/src/evaluator.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { generateEvaluatorFromFunction, runIfTypeOfFunction } from 'alpinejs/src/evaluator'
import { generateEvaluatorFromFunction, shouldAutoEvaluateFunctions } from 'alpinejs/src/evaluator'
import { closestDataStack, mergeProxies } from 'alpinejs/src/scope'
import { tryCatch } from 'alpinejs/src/utils/error'
import { generateRuntimeFunction } from './parser'
import { injectMagics } from 'alpinejs/src/magics'

export function cspEvaluator(el, expression) {
Expand Down Expand Up @@ -28,30 +29,22 @@ function generateEvaluator(el, expression, dataStack) {
return (receiver = () => {}, { scope = {}, params = [] } = {}) => {
let completeScope = mergeProxies([scope, ...dataStack])

let evaluatedExpression = expression.split('.').reduce(
(currentScope, currentExpression) => {
if (currentScope[currentExpression] === undefined) {
throwExpressionError(el, expression)
}
let evaluate = generateRuntimeFunction(expression)

return currentScope[currentExpression]
},
completeScope,
);
let returnValue = evaluate(completeScope)

runIfTypeOfFunction(receiver, evaluatedExpression, completeScope, params)
}
}

function throwExpressionError(el, expression) {
console.warn(
`Alpine Error: Alpine is unable to interpret the following expression using the CSP-friendly build:
if (shouldAutoEvaluateFunctions && typeof returnValue === 'function') {
let nextReturnValue = returnValue.apply(returnValue, params)

"${expression}"

Read more about the Alpine's CSP-friendly build restrictions here: https://alpinejs.dev/advanced/csp

`,
el
)
if (nextReturnValue instanceof Promise) {
nextReturnValue.then(i => receiver(i))
} else {
receiver(nextReturnValue)
}
} else if (typeof returnValue === 'object' && returnValue instanceof Promise) {
returnValue.then(i => receiver(i))
} else {
receiver(returnValue)
}
}
}
Loading