Skip to content

Fix how x-html handles undefined #4555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calebporzio merged 3 commits into from
Feb 9, 2026
Merged

Fix how x-html handles undefined #4555

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eb5b48
Add tests
willrowe Feb 25, 2025
8d0a9dc
Coerce any nullish values to an empty string
willrowe Feb 27, 2025
c593e22
Add newline
willrowe Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/alpinejs/src/directives/x-html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ directive('html', (el, { expression }, { effect, evaluateLater }) => {
effect(() => {
evaluate(value => {
mutateDom(() => {
el.innerHTML = value
el.innerHTML = value ?? ''

el._x_ignoreSelf = true
initTree(el)
Expand Down
22 changes: 22 additions & 0 deletions tests/cypress/integration/directives/x-html.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,25 @@ test('x-html runs even after x-if or x-for',
get('span').should(haveText('bar'))
}
)

test('x-html sets HTML to a blank string when value is `null`',
html`
<div x-data="{ html: null }">
<span x-html="html">original HTML</span>
</div>
`,
({ get }) => {
get('span').should(haveText(''))
}
)

test('x-html sets HTML to a blank string when value is `undefined`',
html`
<div x-data="{ html: undefined }">
<span x-html="html">original HTML</span>
</div>
`,
({ get }) => {
get('span').should(haveText(''))
}
)