Skip to content

Add support for [x-sort:handle] attributes defined in template tags #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimoTod wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −1
Open

Add support for [x-sort:handle] attributes defined in template tags #4483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/sort/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ export default function (Alpine) {

let preferences = {
hideGhost: ! modifiers.includes('ghost'),
useHandles: !! el.querySelector('[x-sort\\:handle]'),
useHandles: (!! el.querySelector('[x-sort\\:handle]')) || Array.from(el.querySelectorAll('template')).some(
tmpl => !! tmpl.content.querySelector('[x-sort\\:handle]')
),
group: getGroupName(el, modifiers),
}

Expand Down
31 changes: 31 additions & 0 deletions tests/cypress/integration/plugins/sort.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,44 @@ test.skip('can use a custom handle',
get('ul li').eq(0).should(haveText('handle - foo'))
get('ul li').eq(1).should(haveText('handle - bar'))

get('#1').drag('#2').then(() => {
get('ul li').eq(0).should(haveText('handle - foo'))
get('ul li').eq(1).should(haveText('handle - bar'))
})

get('#1 span').drag('#2').then(() => {
get('ul li').eq(0).should(haveText('handle - bar'))
get('ul li').eq(1).should(haveText('handle - foo'))
})
},
)

test('can use a custom handle with x-for',
[html`
<div x-data="{items: ['1', '2']}">
<ul x-sort>
<template x-for="item in items" :key="item">
<li :id="item"><span x-sort:handle>handle</span> - <span x-text="item"></span></li>
</template>
</ul>
</div>
`],
({ get }) => {
get('ul li').eq(0).should(haveText('handle - 1'))
get('ul li').eq(1).should(haveText('handle - 2'))

get('#1').drag('#2').then(() => {
get('ul li').eq(0).should(haveText('handle - 1'))
get('ul li').eq(1).should(haveText('handle - 2'))
})

get('#1 span').eq(0).drag('#2').then(() => {
get('ul li').eq(0).should(haveText('handle - 2'))
get('ul li').eq(1).should(haveText('handle - 1'))
})
},
)

test.skip('can move items between groups',
[html`
<div x-data>
Expand Down
Loading