Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/alpinejs/src/mutation.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ function onMutate(mutations) {

mutations[i].addedNodes.forEach(node => {
if (node.nodeType !== 1) return
if (node._x_marker) return

addedNodes.push(node)
})
Expand Down Expand Up @@ -198,7 +197,7 @@ function onMutate(mutations) {

for (let node of addedNodes) {
if (! node.isConnected) continue

if (node._x_marker) return;
onElAddeds.forEach(i => i(node))
}

Expand Down
27 changes: 27 additions & 0 deletions tests/cypress/integration/mutation.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ test('no side effects when directives are added to an element that is removed af
get('span').should(haveText('0'))
}
)

test(
"previously initialized elements are not reinitialized on being moved",
html`
Expand All @@ -243,3 +244,29 @@ test(
get("[x-test]").should(haveText("1"));
}
);

test(
"previously initialized elements are not cleaned up on being moved",
html`
<script>
let count = 0;
document.addEventListener("alpine:init", () => {
Alpine.directive("test", (el, _, { cleanup }) => {
el.textContent = "Initialized";
cleanup(() => {
el.textContent = "Cleaned up";
});
Alpine.nextTick(() => {
el.parentNode.replaceChildren(el);
})
});
});
</script>
<div x-data>
<div class="bg-red-300 w-32 h-32" x-test></div>
</div>
`,
({ get }) => {
get("[x-test]").should(haveText("Initialized"));
}
);