[UI][Tabs] Prevent tab focus on mousedown #4239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Ah this makes total sense and the mousedown prevention listener is a nice solution - I didn't know that would prevent focus but it makes sense. I'm gonna use that in other situations too. Thanks simone! |
This was referenced Jul 10, 2024
This was referenced Jul 11, 2024
Open
Open
Open
Open
Open
Open
This was referenced Jul 18, 2024
Open
Open
Open
Open
Open
Open
This was referenced Jul 25, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 27, 2024
Open
Open
Open
Open
Open
Open
This was referenced Oct 4, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a tab gets the focus when you receive the mousedown event instead of the full click.
This is different from how tabs usually work everywhere else (including Tailwind Headless UI that fixed it with this PR: tailwindlabs/headlessui#1192).
Unfortunately, it's not easily testable because cypress doesn't behave that way but chrome and firefox do.
This seem to cause some interoperability issues with x-dialog too: #4230 (reply in thread) (The OP didn't provide an example though).