Remove extra destroyTree call #4151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Ah good catch. How did you find that it was being called twice? |
Contributor
Author
|
I didn't find this issue through actual usage. I discovered it while reading the source code, as I was very interested in how Alpine is built. |
Collaborator
|
Gotcha, good eye! I tested and you're right, it was getting called twice! Thanks |
This was referenced May 18, 2024
Open
Open
This was referenced May 21, 2024
Open
Open
Open
Open
Open
Open
This was referenced May 29, 2024
Open
Open
This was referenced May 31, 2024
This was referenced Jun 2, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 10, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 17, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
This was referenced Oct 1, 2024
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destroyTreeis hooked intomutation.jsby lifecycle.js#L22, and will be called when an element is removed.If we call it again, then we call it twice.
This PR removes the extra call, and it also eliminates the dependency-cycle between
lifecycle.jsandmutation.js.