Skip to content

Bug: Fixes x-model.fill when used with debounce #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calebporzio merged 2 commits into from
Mar 21, 2024
Merged

Bug: Fixes x-model.fill when used with debounce #4103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80f1ce3
:test_tube: Adds failing .fill.debounce test
ekwoka Mar 20, 2024
7e05a91
:bug: Fixes .fill.debounce conflict
ekwoka Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/alpinejs/src/directives/x-model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ directive('model', (el, { modifiers, expression }, { effect, cleanup }) => {
if (modifiers.includes('fill'))
if ([undefined, null, ''].includes(getValue())
|| (el.type === 'checkbox' && Array.isArray(getValue()))) {
el.dispatchEvent(new Event(event, {}));
setValue(
getInputValue(el, modifiers, { target: el }, getValue())
);
}
// Register the listener removal callback on the element, so that
// in addition to the cleanup function, x-modelable may call it.
Expand Down
12 changes: 12 additions & 0 deletions tests/cypress/integration/directives/x-model.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,3 +282,15 @@ test(
}
);

test(
'x-model with fill and debounce still fills value',
html`
<div x-data="{ a: '' }">
<input type="text" x-model.fill.debounce="a" value="hello" />
</div>
`,
({ get }) => {
get('[x-data]').should(haveData('a', 'hello'));
}
);