Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/alpinejs/src/scope.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ let mergeProxyTrap = {
if (name == Symbol.unscopables) return false;

return objects.some((obj) =>
Object.prototype.hasOwnProperty.call(obj, name)
Reflect.has(obj, name)
);
},

Expand All @@ -57,7 +57,7 @@ let mergeProxyTrap = {

return Reflect.get(
objects.find((obj) =>
Object.prototype.hasOwnProperty.call(obj, name)
Reflect.has(obj, name)
) || {},
name,
thisProxy
Expand All @@ -66,7 +66,7 @@ let mergeProxyTrap = {

set({ objects }, name, value, thisProxy) {
const target = objects.find((obj) =>
Object.prototype.hasOwnProperty.call(obj, name)
Reflect.has(obj, name)
) || objects[objects.length - 1];
const descriptor = Object.getOwnPropertyDescriptor(target, name);
if (descriptor?.set && descriptor?.get)
Expand Down
29 changes: 29 additions & 0 deletions tests/cypress/integration/scope.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,32 @@ test(
get("span#two").should(haveText("foobar"));
}
);

test(
"allows accessing class methods",
[
html`
<script>
class Counter {
value = 0;
constructor() {}
increment() {
this.value++;
}
}
document.addEventListener("alpine:init", () =>
Alpine.data("counter", () => new Counter())
)
</script>
<div x-data="counter">
<button type="button" @click="increment" x-text=value></button>
</div>
`,
],
({ get }) => {
get("button").should(haveText("0"));
get("button").click();
get("button").should(haveText("1"));
}
);