Ensure $listboxOption.isSelected / $comboboxOption.isSelected works if item value is false or 0
#4005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdebrauwer
changed the title
$listboxOption.isSelected / $comboboxOption.isSelected works if item value is false or 0
gdebrauwer
changed the title
$listboxOption.isSelected / $comboboxOption.isSelected works if item value is false or 0$listboxOption.isSelected / $comboboxOption.isSelected works if item value is false or 0
Collaborator
|
Thanks for this! Super valuable! |
This was referenced May 31, 2024
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my application, I noticed that the selected option is not styled correctly when the value of the selected option is
falseor0.Screen.Recording.2024-01-29.at.14.11.15.mov
This is caused by the
isSelectedgetter on$listboxOption/$comboboxOption. That getter always returns false if the item's value is falsy. That is not correct if the item's value is false or 0. This PR fixes that.