-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for 'HTMLElement' type #80
Conversation
Re tests let's chat in #81 |
Btw the project can now be tested with Cypress when changing I've stuck the test for this PR on the todo list at #86 but we can add it here as well. |
Hmmm on second thought, it looks like we need to rethink the way we pass "readonly" attributes to the panel, see the screenshots, We'll need to make HTMLElement fields readOnly in the place that processes the received components
so in short:
Note that this PR fix will only work for top-level elements, not elements inside of Arrays/Objects, we should probably deal with that separately though. |
…ective/alpinejs-devtools into fix/detect-element-data-type
I think this turned out well. Can you take a look when you have time? I can add some tests later this week. I feel I have a pretty decent grasp as to how the codebase works now :) Also, I noticed in the simulator the arrows aren't showing. I think we just need to copy over some CSS that's inlined. I wasn't sure so left it be. We can do it in another branch easily enough though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one on the element name, just a few questions.
Have you tried it out with els: [$el]
? Just wondering if it magically works otherwise I think this is good to merge and we can create a separate issue to deal with HTML elements in nested object/arrays
Edit: I've tried with els: [$el]
and we end up with the same error as the initial issue for this, something about cyclic values, let's raise as a separate issue #96
Fixed this in #95 |
c99f400
to
b8978bb
Compare
Fixes #78
Serializes HTMLElement types and changes the logic on what is readOnly and what readOnly can do.
readOnly
only affects editing now, not opening/closing