Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three tests are not entirely timezone-agnostic #6

Open
leungbk opened this issue Sep 2, 2019 · 2 comments · May be fixed by #8
Open

Three tests are not entirely timezone-agnostic #6

leungbk opened this issue Sep 2, 2019 · 2 comments · May be fixed by #8
Assignees
Labels
bug Something isn't working
Milestone

Comments

@leungbk
Copy link

leungbk commented Sep 2, 2019

The ts-format, ts-parse-org, and ts-parse-element tests seem to involve having either ts-format or ts-unix receive an object without timezone data declared, and then computing a time based on the user's timezone. Consequently, those three tests are failing on my machine, giving me results that are an integral number of hours off. Not the highest priority issue though.

@alphapapa
Copy link
Owner

Thanks for reporting this. Apparently I should run the tests from another time zone, haha.

AFAIK Org timestamps don't support a time zone at all. At least, I can find no mention nor example of time zones in the Org manual section on timestamps, and I don't recall having seen any information about it.

So I think there's nothing to be done in the code itself, unless and until Org adds support for time zones in timestamps.

But for the tests, I guess I'll have to set the time zone manually after parsing.

@alphapapa
Copy link
Owner

See 099ec36 and d1a8ff2. Still need to fix those tests, but at least the failures are now visible here. :)

@alphapapa alphapapa added the bug Something isn't working label Jul 5, 2021
@alphapapa alphapapa added this to the 0.3 milestone Jul 5, 2021
alphapapa added a commit that referenced this issue Jul 5, 2021
@alphapapa alphapapa modified the milestones: 0.3, 0.4 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants