Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Commit

Permalink
Comment: Add comment about fixing the fix
Browse files Browse the repository at this point in the history
  • Loading branch information
alphapapa committed Oct 10, 2018
1 parent b02190f commit 0de8f93
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions matrix-helpers.el
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ PAIRS is a spliced plist."
when value
collect (cons key value)))

;;;; FIXME: Argh

(defun matrix--url-http-create-request (&optional ref-url)
"Create an HTTP request for `url-http-target-url', referred to by REF-URL.
Expand Down Expand Up @@ -303,9 +301,12 @@ modified to allows binary uploads, which are prevented by the
;; Any data
url-http-data))
;; Bug#23750
(unless (or (equal url-http-method "POST")
(= (string-bytes request)
(length request)))
(unless (or
;; Our local fix to the "fix" is to not do the string-bytes/length comparison when
;; POSTing.
(equal url-http-method "POST")
(= (string-bytes request)
(length request)))
(error "Multibyte text in HTTP request: %s" request))
(url-http-debug "Request is: \n%s" request)
request))
Expand Down

0 comments on commit 0de8f93

Please sign in to comment.