Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Escape dots in filter-files-exclude-default regex #32

Merged

Conversation

fritzgrabo
Copy link
Contributor

Just a trivial fix in the filter-files-exclude-default regular expression: I escaped the dots where needed to make sure the regex doesn't accidentally match when it shouldn't.

Before:

(/\.cask/|-autoloads.el|.dir-locals)

After:

(/\.cask/|-autoloads\.el|\.dir-locals)

I only noticed this because I'm working on a package named foobar-dir-locals.el and hit this error:

$ make all
ERROR (2021-02-08 23:58:35): No files specified and not in a git repo.
make: *** [all] Error 1

With the proposed fix in place, everything works as expected.

PS: Thanks so much for this script -- together with Steve Purcell's package-lint, it's been a great help as I start writing and publishing my first packages 馃檶

@alphapapa alphapapa self-assigned this Mar 20, 2021
@alphapapa alphapapa added the bug Something isn't working label Mar 20, 2021
@alphapapa
Copy link
Owner

Thanks for catching that. I'll update the changelog and merge this when I have time.

Thanks also for the kind words. I'm glad it's helpful to you. See also https://github.com/alphapapa/emacs-package-dev-handbook for more resources.

@alphapapa alphapapa force-pushed the master branch 6 times, most recently from 154146c to 52c387d Compare June 23, 2022 04:29
@alphapapa alphapapa added this to the 0.7 milestone Aug 26, 2023
@alphapapa alphapapa force-pushed the fix-filter-files-exclude-default-regex branch from c41b781 to 8fcedab Compare January 6, 2024 23:07
@alphapapa alphapapa merged commit 706f340 into alphapapa:master Jan 6, 2024
@alphapapa
Copy link
Owner

This is finally merged. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants