Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the correct dependency version into the sandbox #41

Closed
josephmturner opened this issue Oct 4, 2023 · 3 comments
Closed

Install the correct dependency version into the sandbox #41

josephmturner opened this issue Oct 4, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@josephmturner
Copy link
Contributor

Example problem: When a built-in dependency has newer version available on ELPA, and the newer version is specified in the Package-Requires of our package, the newer version is not installed, and makem tests our package using the older, built-in version.

makem could call package-install to install the library as a package, which would use the built-in machinery to install dependencies at their correct versions.

@alphapapa
Copy link
Owner

alphapapa commented Oct 4, 2023

Thanks. I think this is technically a bug, because even if --install-deps is used, that won't cause a built-in package to be upgraded to the ELPA version. It just happens rarely in practice (so far, anyway--it's likely to happen more often as more core packages are also put on ELPA).

@alphapapa alphapapa self-assigned this Oct 4, 2023
@alphapapa alphapapa added the bug Something isn't working label Oct 4, 2023
@alphapapa alphapapa added this to the 0.7 milestone Oct 4, 2023
@josephmturner
Copy link
Contributor Author

IIUC, this bug is causing the hyperdrive.el build manifests to fail since the tests are running with the built-in version instead of the latest version which includes this fix.

@josephmturner
Copy link
Contributor Author

josephmturner commented Jan 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants