This repository was archived by the owner on Dec 22, 2023. It is now read-only.
PMI-753: Read Google auth credentials from environment variables #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation is quite similar to how we do this for Piwik token. Since `Pygsheets` doesn't currently support reading credentials from an in-memory data structure, we have had to implement creating a temporary credentials file to do the job. We may revisit this later after the next major release of `Pygsheets`. Also note that, at present, `dotenv` package doesn't support multi-line environment variables properly. Therefore, when running locally, the environment variable `GOOGLE_AUTH_PRIVATE_KEY` cannot be defined in `.env` file and must be defined in the shell. There is a PR currently open on Github repo of `dotenv` which fixes this behaviour, so we'll revisit this later.
galund
reviewed
Nov 6, 2018
galund
suggested changes
Nov 6, 2018
galund
reviewed
Nov 6, 2018
galund
previously approved these changes
Nov 6, 2018
Contributor
galund
left a comment
galund
left a comment
There was a problem hiding this comment.
Small additional comment suggested but apart from that LGTM :)
make it throw exception if a required environment variable doesn't exist.
robinmitra
force-pushed
the
pmi-753-env-var-for-google-sheet
branch
from
6283fcd to
3e0cff8
Compare
galund
approved these changes
Nov 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is quite similar to how we do this for Piwik token.
Since
Pygsheetsdoesn't currently support reading credentials from anin-memory data structure, we have had to implement creating a temporary
credentials file to do the job. We may revisit this later after the
next major release of
Pygsheets.Also note that, at present,
dotenvpackage doesn't support multi-lineenvironment variables properly. Therefore, when running locally, the
environment variable
GOOGLE_AUTH_PRIVATE_KEYcannot be defined in.envfile and must be defined in the shell. There is a PR currentlyopen on the Github repo of
dotenvwhich fixes this behaviour, so we'llrevisit this later.