GTD-1: Added enable_search option to template

[lewisnyman]

See: alphagov/tech-docs-gem#28

[kevindew]

Do we have to use a fork long term?

Looking into it seems we're caught because they've not managed to get manastech/middleman-search#24 merged and a new release :( I wonder if we want to update the comment here to explain why it's a fork since if I understand right you'll get this in every repo that starts from this?

Also any reason why we don't want this to be required by govuk_tech_docs themselves than here.

[lewisnyman]

Thanks, good idea. I've added a link to the PR as a comment.

It seems that adding this line to the tech docs gem is not effective. It has to be added to the main project.

[lewisnyman]

@kevindew I've added a comment now. Thanks for the feedback.

[jonathanglassman]

@kevindew are you happy to approve?

[kevindew]

@lewisnyman no problem.

Re

It seems that adding this line to the tech docs gem is not effective. It has to be added to the main project.

I see, I'm guessing this is because we can't specify a fork in https://github.com/alphagov/tech-docs-gem/blob/master/govuk_tech_docs.gemspec#L32? This seems to create a strange situation where we need to treat this gem separately? Have we considered publishing the fork to resolve this?

I'll approve this now but it'd be good to get the gem situation resolved.

[lewisnyman]

Have we considered publishing the fork to resolve this?

Not really, I don't feel like that's a decision I can make and I haven't raised it more widely yet. If we have to continue maintaining this fork for a substantial amount of time it feels like a logical next step.

Thanks for reviewing!