TRG-145: Support sites which use relative URLs. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves using the site's URL, in combination with the relative URLs returned in `/api/pages.json` and using them to build absolute an absolute URL to each page which is to be notified upon. Sites which use absolute links are unaffected.
eddgrant
changed the title
lfdebrux
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently the data returned in
/api/pages.jsonreports all page paths as being deployed at "/", this doesn't work for sites which are deployed at a path other than "/" e.g. "/my-docs-as-code-site".This is a companion change to alphagov/tech-docs-gem#291, which changes the content of
/api/pages.jsonto report pages as relative paths to the/api/pages.jsonpage. This allowstech-docs-monitorto use the site's absolute URL (which it has in config) and combine this with the relative path of each page, to build absolute an absolute URL to each page.As far as I can tell from my testing sites which use absolute links are unaffected, so this shouldn't be a breaking change for existing users of sites deployed at "/" who want to upgrade.