This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Remove export get-involved features and corresponding steps #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for the get-involved page have been written in government-frontend now [1], so we can now remove these features that don't meet the Smokey eligibility criteria. [1]: alphagov/government-frontend#2473
This has been changed so that the step_defintion file matches the file name of the feature (which seems to be the convention). Looking in this file I do wince somewhat at the fragility of the selector that was written here. That's going to hurt someone one day 😬
benthorner
approved these changes
Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #950
Tests for the get-involved page have been written in government-frontend
now 1, so we can now remove these features that don't meet the Smokey
eligibility criteria.
Testing
You should manually test your PR before merging.
See https://github.com/alphagov/smokey/blob/main/docs/deployment.md