Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Commit

Permalink
Remove export get-involved features and corresponding steps
Browse files Browse the repository at this point in the history 
Tests for the get-involved page have been written in government-frontend
now [1], so we can now remove these features that don't meet the Smokey
eligibility criteria.

[1]: alphagov/government-frontend#2473
  • Loading branch information
@kevindew
kevindew committed Jun 29, 2022
1 parent 8b50cc4 commit c1397b7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 150 deletions.
114 changes: 0 additions & 114 deletions features/apps/government_frontend.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,125 +21,11 @@ Feature: Government Frontend
And I click on the button "Continue"
Then I should see "How often do you want to get emails?"

# TODO: EXPORT this test as it does not meet the eligibility
# criteria in docs/writing-tests.md.
#
# - Covers site-wide config: N (not applicable)
# - Targets data transfer: N (already covered)
# - Second critical check: N (not tested in app)
#
# Data transfer with Content Store is already covered by
# "Check the frontend can talk to Content Store". These links
# are not a critical feature of GOV.UK.
#
# Should be tested in app [^1].
#
# [^1]: https://github.com/alphagov/government-frontend/blob/main/app/helpers/get_involved_helper.rb
#
Scenario Outline: Ensure search links are correct
When I visit "/government/get-involved"
Then I should see the search link "<SearchLinkText>"
And it should link to "<SearchPage>"

Examples:
| SearchLinkText | SearchPage |
| Search all consultations | /search/policy-papers-and-consultations?content_store_document_type%5B%5D=open_consultations&content_store_document_type%5B%5D=closed_consultations |
| Open consultations | /search/policy-papers-and-consultations?content_store_document_type=open_consultations |
| Closed consultations | /search/policy-papers-and-consultations?content_store_document_type=closed_consultations |

# TODO: EXPORT this test as it does not meet the eligibility
# criteria in docs/writing-tests.md.
#
# - Covers site-wide config: N (not applicable)
# - Targets data transfer: N (already covered)
# - Second critical check: N (not tested in app)
#
# Data transfer with Search API is already covered by
# "Check the frontend can talk to Search API".
#
# Should be tested in app [^1], but only partially tested [^2].
#
# [^1]: https://github.com/alphagov/government-frontend/blob/5f0256bd85347d5bba0d130aa986fc643e001f57/app/views/content_items/get_involved.html.erb#L73-L86
# [^2]: https://github.com/alphagov/government-frontend/blob/5f0256bd85347d5bba0d130aa986fc643e001f57/test/controllers/get_involved_controller_test.rb
#
Scenario: Ensure Next Closing box is populated
When I visit "/government/get-involved"
Then I should see the next closing box
And it should be populated
When I click the next closing response link
Then I should see the next closing consultation

Scenario: Check the frontend can talk to Search API
When I visit "/government/get-involved"
Then I should see "Recently opened"
And it should be populated with three open consultations

# TODO: EXPORT this test as it does not meet the eligibility
# criteria in docs/writing-tests.md.
#
# - Covers site-wide config: N (not applicable)
# - Targets data transfer: N (already covered)
# - Second critical check: N (not tested in app)
#
# Data transfer with Search API is already covered by
# "Check the frontend can talk to Search API".
#
# Should be tested in app [^1], but only partially tested [^2].
#
# [^1]: https://github.com/alphagov/government-frontend/blob/5f0256bd85347d5bba0d130aa986fc643e001f57/app/views/content_items/get_involved.html.erb#L105-L122
# [^2]: https://github.com/alphagov/government-frontend/blob/5f0256bd85347d5bba0d130aa986fc643e001f57/test/controllers/get_involved_controller_test.rb
#
Scenario: Ensure we can see three recent consultation outcomes
When I visit "/government/get-involved"
Then I should see "Recent outcomes"
And it should be populated with three closed consultations

# TODO: EXPORT this test as it does not meet the eligibility
# criteria in docs/writing-tests.md.
#
# - Covers site-wide config: N (not applicable)
# - Targets data transfer: N (already covered)
# - Second critical check: N (not tested in app)
#
# Data transfer with Content Store is already covered by
# "Check the frontend can talk to Content Store".
#
# This test also fails frequently due to the unconventional
# test approach of actually clicking the links [^1].
#
# Should be tested in app [^2].
#
# [^1]: https://github.com/alphagov/smokey/issues/950
# [^2]: https://github.com/alphagov/government-frontend/blob/5f0256bd85347d5bba0d130aa986fc643e001f57/app/controllers/get_involved_controller.rb#L29
#
Scenario Outline: Ensure the Take Part pages are populated
When I visit "/government/get-involved"
Then I should see "Take part"
And I should see "<Title>"
When I click on the link "<Title>"
Then I should be at a location path of "<Path>"

Examples:
| Title | Path |
| Volunteer | /government/get-involved/take-part/volunteer |
| National Citizen Service | /government/get-involved/take-part/national-citizen-service |
| Start a public service mutual | /government/get-involved/take-part/start-a-public-service-mutual |
| Set up a new school | /government/get-involved/take-part/set-up-a-new-school |
| Help make your neighbourhood a safer place | /government/get-involved/take-part/help-make-your-neighbourhood-a-safer-place |
| Decide where homes, shops and businesses should be built | /government/get-involved/take-part/decide-where-new-homes-shops-facilities-and-businesses-should-be-built |
| Challenge to run a local service | /government/get-involved/take-part/challenge-to-run-a-local-service |
| Improve your social housing | /government/get-involved/take-part/improve-your-social-housing |
| Protect a local building | /government/get-involved/take-part/protect-a-local-building |
| Organise a street party | /government/get-involved/take-part/organise-a-street-party |
| Take over a local pub, shop, or green space for the community | /government/get-involved/take-part/take-over-a-local-pub-shop-or-green-space-for-the-community |
| Volunteer as a school governor | /become-school-college-governor |
| Set up a town or parish council | /government/get-involved/take-part/set-up-a-town-or-parish-council |
| Invest in local enterprises | /government/get-involved/take-part/invest-in-local-enterprises |
| Help run a charity | /government/get-involved/take-part/help-run-a-charity |
| Make a neighbourhood plan | /government/get-involved/take-part/make-a-neighbourhood-plan |
| Create a community library | /government/get-involved/take-part/create-a-community-library |
| Become a councillor | /government/get-involved/take-part/become-a-councillor |

Scenario: Check a travel advice country page loads
When I visit "/foreign-travel-advice/luxembourg"
Then I should see "Luxembourg"
Expand Down
36 changes: 0 additions & 36 deletions features/step_definitions/get_involved_page_steps.rb
View file
Original file line number Diff line number Diff line change
@@ -1,41 +1,5 @@
Then /^I should see the next closing box$/ do
expect(page).to have_css(".gem-c-inset-text")
end

And /^it should be populated$/ do
within ".gem-c-inset-text.govuk-inset-text" do
expect(page).to have_css(".govuk-body")
@title = find(:xpath, "p").native.text
end
end

When /^I click the next closing response link$/ do
within ".gem-c-inset-text" do
click_link "Read and respond"
end
end

Then /^I should see the next closing consultation$/ do
expect(page).to have_content(@title)
end

And /^it should be populated with three open consultations$/ do
within ".get-involved > div:nth-child(4) > div" do
expect(page).to have_css(".gem-c-document-list__item-title", count: 3)
end
end

And /^it should be populated with three closed consultations$/ do
within ".get-involved > div:nth-child(5) > div" do
expect(page).to have_css(".gem-c-document-list__item-title", count: 3)
end
end

Then /^I should see the search link "(.*?)"$/ do |link|
expect(page).to have_content(link)
@linktext = link
end

And /^it should link to "(.*?)"$/ do |link|
have_link(@linktext, :href => link)
end

0 comments on commit c1397b7

Please sign in to comment.