Add pages array to worldwide organisations #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkempster34
force-pushed
the
add-pages-to-worldwide-organisations
branch
from
3755319 to
82b560d
Compare
brucebolt
previously approved these changes
Feb 14, 2024
As part of a larger piece of work to make worldwide organisations editionable, we want to implement a type of "multi-part" content for worldwide organisation corporate information pages. These pages require a summary in addition to the properties already defined.
As part of a larger piece of work to make worldwide organisations editionable, we want to implement a type of "multi-part" content for worldwide organisation corporate information pages. This means that corporate information pages associated with worldwide organisations will no longer have their own content items, they will instead be part of the worldwide organisation itself. This benefits us as we will not have to keep the state of worldwide organisations and corporate information pages in sync, allowing us to simplify worldwide organisations in Whitehall. As part of our migration plan from worldwide organisations to editionable worldwide organisations, we intend to compare content items to ensure parity. Therefore, this updates the worldwide organisation to add the required pages array.
jkempster34
force-pushed
the
add-pages-to-worldwide-organisations
branch
from
82b560d to
ad62c11
Compare
Some corporate information pages are shown as a list. Currently, we link to these by retrieving the path from the corporate information page links. Now that we are removing links, we need another way to associate the ordered corporate information pages with each page.
jkempster34
force-pushed
the
add-pages-to-worldwide-organisations
branch
from
ad62c11 to
373428e
Compare
These examples are used for testing in Government Frontend. This: - Adds `page_parts` array to enable multi-part content for worldwide organisation pages. - Removes personal information charter from `ordered_corporate_information_pages` as this is a secondary corporate information page
jkempster34
force-pushed
the
add-pages-to-worldwide-organisations
branch
from
373428e to
5eca0bc
Compare
jkempster34
added a commit
to alphagov/government-frontend
that referenced
this pull request
Feb 20, 2024
Currently, the worldwide organisation example JSON is incorrect; it contains: - The link to "Personal information charter" as a corporate information page with a full URL - A secondary corporate information page with a relative URL. The former shouldn't be present, and this test relies on it's existence. This updates the test so that the corporate information page link can be removed in alphagov/publishing-api#2637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/npYpoK31
Add optional summary property to parts
As part of a larger piece of work to make worldwide organisations editionable,
we want to implement a type of "multi-part" content for worldwide organisation
corporate information pages.
These pages require a summary in addition to the properties already defined.
Add pages array to worldwide organisations
As part of a larger piece of work to make worldwide organisations editionable,
we want to implement a type of "multi-part" content for worldwide organisation
corporate information pages.
This means that corporate information pages associated with worldwide
organisations will no longer have their own content items, they will instead be
part of the worldwide organisation itself.
This benefits us as we will not have to keep the state of worldwide
organisations and corporate information pages in sync, allowing us to simplify
worldwide organisations in Whitehall.
As part of our migration plan from worldwide organisations to editionable
worldwide organisations, we intend to compare content items to ensure parity.
Therefore, this updates the worldwide organisation to add the required pages
array.
Add path attribute to ordered corporate information pages
Some corporate information pages are shown as a list.
Currently, we link to these by retrieving the path from the corporate
information page links.
Now that we are removing links, we need another way to associate the ordered
corporate information pages with each page.
Update worldwide organisation example
These examples are used for testing in Government Frontend.
This:
page_partsarray to enable multi-part content for worldwideorganisation pages.
ordered_corporate_information_pagesas this is a secondary corporateinformation page
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.