Deprecate the use of Plek.current #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengi
approved these changes
Oct 3, 2022
kevindew
added a commit
to alphagov/gds-api-adapters
that referenced
this pull request
Oct 3, 2022
This has been deprecated [1] since Plek 4.1 [2]. Instead we can use forego the need for a current method and call find directly. [1]: alphagov/plek#94 [2]: alphagov/plek#92
kevindew
added a commit
to alphagov/gds-api-adapters
that referenced
this pull request
Oct 3, 2022
This has been deprecated [1] since Plek 4.1 [2]. Instead we can use forego the need for a current method and call find directly. [1]: alphagov/plek#94 [2]: alphagov/plek#92
brucebolt
added a commit
to alphagov/content-store
that referenced
this pull request
Oct 5, 2022
Usage of `Plek.current` was marked as deprecated in alphagov/plek#94, therefore we should remove uses of the old syntax before upgrading Plek, else we'll log lots of deprecation warnings.
brucebolt
added a commit
to alphagov/content-store
that referenced
this pull request
Oct 5, 2022
Usage of `Plek.current` was marked as deprecated in alphagov/plek#94, therefore we should remove uses of the old syntax before upgrading Plek, else we'll log lots of deprecation warnings.
brucebolt
added a commit
to alphagov/publishing-api
that referenced
this pull request
Oct 5, 2022
Usage of `Plek.current` was marked as deprecated in alphagov/plek#94, therefore we should remove uses of the old syntax before upgrading Plek, else we'll log lots of deprecation warnings.
ChrisBAshton
added a commit
to alphagov/content-data-admin
that referenced
this pull request
Oct 5, 2022
Usage of `Plek.current` was marked as deprecated in alphagov/plek#94, therefore we should remove uses of the old syntax before upgrading Plek, else we'll log lots of deprecation warnings. See also alphagov/publishing-api#2158
AgaDufrat
added a commit
to alphagov/government-frontend
that referenced
this pull request
Oct 5, 2022
It's going to be deprecated alphagov/plek#94
AgaDufrat
added a commit
to alphagov/collections
that referenced
this pull request
Oct 5, 2022
It's going to be deprecated alphagov/plek#94
AgaDufrat
added a commit
to alphagov/static
that referenced
this pull request
Oct 5, 2022
It's going to be deprecated alphagov/plek#94
AgaDufrat
added a commit
to alphagov/static
that referenced
this pull request
Oct 5, 2022
It's going to be deprecated alphagov/plek#94
AgaDufrat
added a commit
to alphagov/government-frontend
that referenced
this pull request
Oct 5, 2022
It's going to be deprecated alphagov/plek#94
leenagupte
added a commit
to alphagov/finder-frontend
that referenced
this pull request
Oct 5, 2022
`Plek.current` was marked as deprecated in alphagov/plek#94. This replaces all uses of `Plek.current` to stop deprecation warnings from filling up the logs with: "Plek.current is deprecated and will be removed. Use Plek.new or Plek.find instead."
gclssvglx
added a commit
to alphagov/feedback
that referenced
this pull request
Oct 6, 2022
`Plek.current` was marked as deprecated in alphagov/plek#94. This replaces all uses of `Plek.current` to stop deprecation warnings from filling up the logs with: "Plek.current is deprecated and will be removed. Use Plek.new or Plek.find instead."
gclssvglx
added a commit
to alphagov/search-api
that referenced
this pull request
Oct 6, 2022
`Plek.current` was marked as deprecated in alphagov/plek#94. This replaces all uses of `Plek.current` to stop deprecation warnings from filling up the logs with: "Plek.current is deprecated and will be removed. Use Plek.new or Plek.find instead."
gclssvglx
added a commit
to alphagov/search-admin
that referenced
this pull request
Oct 6, 2022
`Plek.current` was marked as deprecated in alphagov/plek#94. This replaces all uses of `Plek.current` to stop deprecation warnings from filling up the logs with: "Plek.current is deprecated and will be removed. Use Plek.new or Plek.find instead."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was put in temporarily 10 years ago 1 and has had a todo next to it ever since. We're planning to finally remove this 2 in the 5.0 release so this acts as a warning in the interim.