PP-12854 Parity check - omit unnecessary fields and handle connector 404 #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-peacock-gds
changed the title
nlsteers
reviewed
Sep 17, 2024
nlsteers
reviewed
Sep 17, 2024
- correct the diff filtering logic so that relevant differences are all included - lay out page so that the diff kinds (different fields, missing fields) are under sub-headings
nlsteers
reviewed
Sep 19, 2024
src/web/modules/transactions/discrepancies/validateLedger.http.ts
Outdated
Show resolved
Hide resolved
src/web/modules/transactions/discrepancies/validateLedger.http.ts
Outdated
Show resolved
Hide resolved
src/web/modules/transactions/discrepancies/validateLedger.http.ts
Outdated
Show resolved
Hide resolved
nlsteers
reviewed
Sep 19, 2024
| text: warningMessage, | ||
| {% if message %} | ||
| {{ govukInsetText({ | ||
| text: message, | ||
| iconFallbackText: "Warning" |
There was a problem hiding this comment.
this iconFallbackText parameter is probably not needed anymore
nlsteers
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The parity check in toolbox compares responses from connector and ledger in relation to a given transaction. It should only check the fields that are common to both responses, highlighting any missing or different fields. If connector returns 404 (charge not found), a message should be displayed rather than an error page.
Screenshot: Charge not found in connector:
Screenshot: Differences found: