Set default timezone to London in config #2205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgisbey
force-pushed
the
set-default-timezone-to-london-in-config
branch
from
cb9f673 to
b4a2720
Compare
We've had a bug come in that a that was published at 12.01am is saying that it was published the previous day on the updates section. Looking at the config I can see that a default timezone hasn't been set. This means it's using UTC. This doesn't account for BST being an hour ahead during the summer time so when the updated_at is passed to publising API it's passing a time of an hour earlier than it was published. We can resolve this by setting the default timezone to London. A bulk republish will be required to resolve this issue too.
davidgisbey
force-pushed
the
set-default-timezone-to-london-in-config
branch
from
b4a2720 to
eedfdab
Compare
|
closing in place of alphagov/government-frontend#2959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've had a bug come in that a that was published at 12.01am is saying that it was published the previous day on the updates section.
Looking at the config I can see that a default timezone hasn't been set. This means it's using UTC. This doesn't account for BST being an hour ahead during the summer time so when the updated_at is passed to Publishing API it's passing a time of an hour earlier than it was published.
We can resolve this by setting the default timezone to London.
As this is a pre-existing bug that's basically always existed, we run into a bit of an issue with data integrity of previous manuals. We can simply republish the most recent published edition of the manual, but there could be quite a large amount of editions which have the incorrect date that won't be updated.
It might be that tackling that in Publishing API itself is the right way to go.
Trello card
https://trello.com/c/idVD4RQT/1794-update-history-shows-the-wrong-date
Follow these steps if you are doing a Rails upgrade.