Add 'hide_order_copy_link' parameter to hide 'Order a copy' #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBAshton
force-pushed
the
hide-order-copy-link-from-admins
branch
from
3b89313 to
ff56da5
Compare
benthorner
approved these changes
Apr 3, 2020
Attachment is used on admin-facing pages as well as user-facing pages. Their requirements for a preview are somewhat different, and having 'Order a copy' doesn't fit the design for them. I've chosen to make this a boolean, following the style of the 'hide_opendocument_metadata' parameter, rather than inventing some sort of 'admin context' which is open to misinterpretation.
ChrisBAshton
force-pushed
the
hide-order-copy-link-from-admins
branch
from
ff56da5 to
7672fa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & why
Attachment is used on admin-facing pages as well as user-facing
pages. Their requirements for a preview are somewhat different,
and having 'Order a copy' doesn't fit the design for them.
I've chosen to make this a boolean, following the style of the
'hide_opendocument_metadata' parameter, rather than inventing
some sort of 'admin context' which is open to misinterpretation.
Trello: https://trello.com/c/UET4vx6k/1439-update-attachment-component-to-accommodate-new-attachment-design
Visual Changes
See https://govuk-publis-hide-order-mpkgzj.herokuapp.com/component-guide/attachment