Mobile breadcrumb update guidance

[RobBond-GDS]

On mobile devices update breadcrumb behaviour as per :

https://trello.com/c/YuObLgSq/10-fix-breadcrumbs-on-mobile

What

Update guidance documentation to remove patterns with "is_current_page"

Why

When a breadcrumb on a mobile device is collapsed, if last item is set as "is_current_page" then it is not possible to navigate to parent items. To eliminate the inconsistency, this option has been removed

[vanitabarrett]

The logic which handles this flag is still present and needs to be removed, e.g: https://github.com/alphagov/govuk_publishing_components/blob/master/lib/govuk_publishing_components/presenters/breadcrumbs.rb#L46

We should double check we're not using this flag anywhere before removing it.

[andysellick]

https://github.com/alphagov/finder-frontend/blob/master/app/presenters/finder_breadcrumbs_presenter.rb#L20
https://github.com/alphagov/govuk_publishing_components/blob/master/lib/govuk_publishing_components/presenters/breadcrumbs.rb

[vanitabarrett]

There is still some code in the breadcrumbs.rb checking for is_current_page
https://github.com/alphagov/govuk_publishing_components/blob/master/lib/govuk_publishing_components/presenters/breadcrumbs.rb#L85

[vanitabarrett]

@RobBond-GDS Looks good, but not sure why there's a merge commit here - can we rebase to remove it?

[RobBond-GDS]

Have rebased as requested

…

On Wed, 19 Feb 2020 at 09:43, Vanita Barrett ***@***.***> wrote: @RobBond-GDS <https://github.com/RobBond-GDS> Looks good, but not sure why there's a merge commit here - can we rebase to remove it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1298?email_source=notifications&email_token=ANAYF7G4KQPG4FPHV7T5VWLRDT5NBA5CNFSM4KWPEZH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMHB3JQ#issuecomment-588127654>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANAYF7FW6NKXQBULWO2SKM3RDT5NBANCNFSM4KWPEZHQ> .