Allow custom heading size on fieldset component #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the current inline html with sanitize examples we now promote nesting components within the fieldset using the yield block.
Instead of using custom html for inserting headings within the legend we now promote the `heading_level` option.
No, we still allow sanitised html to be passed in as values (including to the |
yeah, i notice that after i've posted and then deleted the comment 🚢 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow custom heading size on fieldset component.
Why
So we can generate custom headings within legends consistently across GOV.UK
Visual Changes
No visual changes
View Changes
Before: https://components.publishing.service.gov.uk/component-guide/fieldset
After: https://govuk-publishing-compo-pr-1223.herokuapp.com/component-guide/fieldset
Trello card