Skip to content

Commit

Permalink
Remove heading helper from search component
Browse files Browse the repository at this point in the history
- not used
- also remove it from the auditing tools, because it's only used by one other component (the heading component) and we only need to audit helpers that are used by multiple components, lots of components already have their own individual helpers
  • Loading branch information
andysellick committed Dec 3, 2024
1 parent bf587d3 commit 9c92b9b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
6 changes: 0 additions & 6 deletions app/models/govuk_publishing_components/audit_components.rb
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,6 @@ def get_helper_usage(components)
match: /(GovukPublishingComponents::Presenters::ComponentWrapperHelper.new)/,
used_by: [],
},
{
name: "Heading helper",
link: "lib/govuk_publishing_components/presenters/heading_helper.rb",
match: /(GovukPublishingComponents::Presenters::HeadingHelper.new)/,
used_by: [],
},
{
name: "Shared helper",
link: "lib/govuk_publishing_components/presenters/shared_helper.rb",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
add_gem_component_stylesheet("label")

shared_helper = GovukPublishingComponents::Presenters::SharedHelper.new(local_assigns)
heading_helper = GovukPublishingComponents::Presenters::HeadingHelper.new(local_assigns)

aria_controls ||= nil
button_text ||= t("components.search_box.search_button")
Expand Down
6 changes: 0 additions & 6 deletions spec/component_guide/audit_components_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,6 @@
},
],
},
{
link: "lib/govuk_publishing_components/presenters/heading_helper.rb",
match: /(GovukPublishingComponents::Presenters::HeadingHelper.new)/,
name: "Heading helper",
used_by: [],
},
{
link: "lib/govuk_publishing_components/presenters/shared_helper.rb",
match: /(GovukPublishingComponents::Presenters::SharedHelper.new)/,
Expand Down

0 comments on commit 9c92b9b

Please sign in to comment.