-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Dependabot ignore eslint
and eslint-*
#4999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint
and eslint-*
packages
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 2a929e9 |
eslint
and eslint-*
packageseslint
and eslint-*
880f9eb
to
91fe48c
Compare
Dependabot keeps timing out before completing and on inspection of the logs, the latest package it attempts to install is `eslint-plugin-n`. This commit makes Dependabot ignore the eslint packages until we are able to update them all, as this is currently blocked by not all the plugins supporting the latest version of the `eslint` config.
91fe48c
to
2a929e9
Compare
romaricpascal
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this a spin. ⛵
After merge, let's try and trigger a dependabot run from the web UI.
1 task
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds
eslint
andeslint-*
to packages that Dependabot should ignore.Why
Dependabot keeps timing out before completing (issue #4982) and on inspection of the logs, it appears that the last package it attempts to install is
eslint-plugin-n
. Attempting to install this package locally results in a peer dependency error. As we are currently waiting to updateeslint
and it's associated plugins to their latest versions, it makes sense to stop Dependabot from updatingeslint
and associated plugins until we can update them all at once.(Perhaps) addresses #4982