Update default Exit This Page button text #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/govuk-frontend/src/govuk/components/exit-this-page/template.njk
Outdated
Show resolved
Hide resolved
packages/govuk-frontend/src/govuk/components/exit-this-page/exit-this-page.yaml
Show resolved
Hide resolved
packages/govuk-frontend/src/govuk/components/exit-this-page/template.njk
Outdated
Show resolved
Hide resolved
querkmachine
force-pushed
the
update-etp-default-text
branch
from
f0a1d51 to
fd7af09
Compare
colinrotherham
approved these changes
Jul 27, 2023
|
|
||
| The default text of the Exit this Page button has been updated to indicate that the button is a safety tool and not a generic method of leaving the current page. If you are using the component's default label, you may wish to update it to the new value. | ||
|
|
||
| ```diff |
|
|
||
| ```diff | ||
| <a href="..." role="button" draggable="false" class="govuk-button govuk-button--warning govuk-exit-this-page__button govuk-js-exit-this-page-button" data-module="govuk-button"> | ||
| - Exit this page |
| ```diff | ||
| <a href="..." role="button" draggable="false" class="govuk-button govuk-button--warning govuk-exit-this-page__button govuk-js-exit-this-page-button" data-module="govuk-button"> | ||
| - Exit this page | ||
| + <span class="govuk-visually-hidden">Emergency</span> Exit this page |
romaricpascal
pushed a commit
that referenced
this pull request
Aug 7, 2023
Update default Exit This Page button text
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the default Exit This Page button text to include visually hidden text, so the button reads 'Emergency Exit this Page' to screen reader users, to clarify the button's intended use as a safety feature.
Split out from #3878. Intended to resolve #3688.
I assume this would need a 'Suggested change' in the changelog now that EtP has shipped in 4.7.0?