(re-)Remove IE8–10 related Sass and CSS build tasks #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
approved these changes
May 3, 2023
colinrotherham
force-pushed
the
review-app-user
branch
from
1593117 to
b3de34b
Compare
colinrotherham
force-pushed
the
review-app-user
branch
from
b3de34b to
48e5ab3
Compare
colinrotherham
force-pushed
the
remove-ie8-css
branch
from
d736de5 to
6202660
Compare
|
Rebased to include today's PR merges |
colinrotherham
force-pushed
the
review-app-user
branch
from
48e5ab3 to
2c2a9d9
Compare
colinrotherham
force-pushed
the
remove-ie8-css
branch
from
6202660 to
78f4120
Compare
colinrotherham
force-pushed
the
review-app-user
branch
from
2c2a9d9 to
6d9eb1a
Compare
Removes uses of the `govuk-if-ie8` and `govuk-not-ie8` mixins from Sass, removing IE8 specific code in the process, whilst maintaing any non-IE8 code. This commit does not remove the mixins themselves.
Clean up some other code which wasn't specifically scoped to IE8, but where the code structure had been altered to accommodate IE8.
…syntax. We can change from single colons to double colons, as single colons were only needed for IE8 support. Includes a temporary override of the GDS Stylelint configuration to not raise complaints about the use of double colons.
colinrotherham
force-pushed
the
remove-ie8-css
branch
from
78f4120 to
9862a1e
Compare
This was referenced May 4, 2023
|
@querkmachine We've merged #3491 so this one is good to go 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #3559 which was accidentally merged prematurely.