-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to new Chrome headless mode #3543
Conversation
Timing stats using Chrome for Testing on Puppeteer v20 Note: Percy previously downloaded its own Chromium even though we used Puppeteer BeforeUsing old headless mode Accessibility tests: 1m 53s AfterUsing new headless mode Accessibility tests: 2m 8s |
2f2d84a
to
37717f4
Compare
37717f4
to
493c7db
Compare
493c7db
to
8628ae1
Compare
8628ae1
to
f0b8d76
Compare
Do you know if the Puppeteer team are aware that tests running under the new headless modes are slower? Is it something they're working to improve? Sharding the accessibility tests is a neat idea (TIL that's a thing!) but I feel like our GitHub Actions are starting to get a little complex. Wondering if we should either wait until the performance of the new headless mode improves, or just accept that our tests will be a little bit slower for a while? |
From some of the comments they're aware of it (approx 30% slower), but appreciate it's now the same full browser for both headless and headful modes
Ha that's great. I'd always wanted to try For context this PR was thinking our But it's still holding strong |
f0b8d76
to
e722993
Compare
I've rebased with #3491 and removed the No rush to approve this one but good to know it works when we need it |
The second timing block in #3543 (comment) is the "After" one (both say "before")? |
@OrKoN Ahh thanks, updated! |
e722993
to
5cc3e42
Compare
@36degrees I've updated the timing stats after rebasing with Puppeteer v20: The switch to Chrome for Testing (not Chromium) has closed the gap 🙌 |
Although since the ~600 accessibility tests merged we've drifted a lot from the 2m 30s sweet spot we once had |
5cc3e42
to
53b9883
Compare
53b9883
to
67d4ada
Compare
67d4ada
to
1996a12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timings now look pretty much the same as on main, let's merge this 🥳 ⛵
Since #3543 (or perhaps in recent Puppeteer updates) we're seeing much more accurate timers Running assertions at the exact `setTimeout()` or `setInterval()` periods can fail the test so I've added 50ms on
Since #3543 (or perhaps in recent Puppeteer updates) we're seeing much more accurate timers Running assertions at the exact `setTimeout()` or `setInterval()` periods can fail the test so I've added 50ms on
Instead of counting events that may or may not bubble up to a `<form>` we now count every click + debounce Since #3543 (or perhaps in recent Puppeteer updates) we're seeing much more accurate timers Running assertions at the exact `setTimeout()` or `setInterval()` periods can fail the test so I've added 50ms on
Since #3543 (or perhaps in recent Puppeteer updates) we're seeing much more accurate timers Running assertions at the exact `setTimeout()` or `setInterval()` periods can fail the test so I've added 50ms on
Instead of counting events that may or may not bubble up to a `<form>` we now count every click + debounce Since #3543 (or perhaps in recent Puppeteer updates) we're seeing much more accurate timers Running assertions at the exact `setTimeout()` or `setInterval()` periods can fail the test so I've added 50ms on
Since #3543 (or perhaps in recent Puppeteer updates) we're seeing much more accurate timers Running assertions at the exact `setTimeout()` or `setInterval()` periods can fail the test so I've added 50ms on
Instead of counting events that may or may not bubble up to a `<form>` we now count every click + debounce Since #3543 (or perhaps in recent Puppeteer updates) we're seeing much more accurate timers Running assertions at the exact `setTimeout()` or `setInterval()` periods can fail the test so I've added 50ms on
Switch to new Chrome headless mode
Since #3543 (or perhaps in recent Puppeteer updates) we're seeing much more accurate timers Running assertions at the exact `setTimeout()` or `setInterval()` periods can fail the test so I've added 50ms on
Instead of counting events that may or may not bubble up to a `<form>` we now count every click + debounce Since #3543 (or perhaps in recent Puppeteer updates) we're seeing much more accurate timers Running assertions at the exact `setTimeout()` or `setInterval()` periods can fail the test so I've added 50ms on
Following #3542 just a quick PR for:
For more info on our headless mode deprecation issues see:
{ headless: true }
puppeteer/puppeteer#10070