Skip to content

Allow Node.js LTS ‘Gallium’ (v16) release version#2939

Merged
colinrotherham merged 1 commit into
mainfrom
node-versions
Oct 24, 2022
Merged

Allow Node.js LTS ‘Gallium’ (v16) release version#2939
colinrotherham merged 1 commit into
mainfrom
node-versions

Conversation

@colinrotherham

@colinrotherham colinrotherham commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

This PR lowers the minimum Node.js 16 and npm versions allowed

Why? Across our projects we have a mismatch in our supported Node.js versions. This makes npm link a bit painful with tools like nvm and asdf as they partition dependencies by Node.js version

lts/galliumhttps://github.com/alphagov/govuk-frontend/blob/main/.nvmrc
16.14.2https://github.com/alphagov/govuk-design-system/blob/main/.nvmrc
16.16.0https://github.com/alphagov/govuk-prototype-kit/blob/v13/.nvmrc

Before

Latest Node.js LTS ‘Gallium’ (v16) release when #2842 was opened

"engines": {
  "node": "^16.17.0",
  "npm": "^8.5.0"
},

After

All Node.js LTS ‘Gallium’ (v16) releases from initial LTS launch are now supported

"engines": {
  "node": "^16.13.0",
  "npm": "^8.1.0"
},

Ensure any Node.js LTS ‘Gallium’ minor/patch release (and bundled npm version) is allowed to run without issue

https://github.com/nodejs/node/releases/tag/v16.13.0

@36degrees 36degrees left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense👍🏻

@colinrotherham

Copy link
Copy Markdown
Contributor Author

@colinrotherham colinrotherham merged commit 46d0462 into main Oct 24, 2022
@colinrotherham colinrotherham deleted the node-versions branch October 24, 2022 12:45
@colinrotherham

Copy link
Copy Markdown
Contributor Author

Update now #2939, alphagov/govuk-prototype-kit#1712 and alphagov/govuk-design-system#2399 are merged:

lts/galliumhttps://github.com/alphagov/govuk-frontend/blob/main/.nvmrc
lts/galliumhttps://github.com/alphagov/govuk-design-system/blob/main/.nvmrc
lts/*https://github.com/alphagov/govuk-prototype-kit/blob/v13/.nvmrc

Once development environments are upgraded, package.json engines field changed, GitHub workflows bumped up, tests pass (and Heroku stacks upgraded to match) etc we may also want the lts/* alias everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

3 participants