-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination component #2610
Add pagination component #2610
Conversation
Is there a review app for this? From the screenshots it looks like there might be errant whitespace in the previous and next links - the underlines look oddly sized for the text content. |
The title and label lines on the "block" view are also not aligned with one another, possibly due to unruly whitespace again. @edwardhorsford We don't have review apps at the moment due to the GitHub/Heroku outage. You need to pull the branch and run it locally for the time being. |
@querkmachine that's out of alignment too - but what I was talking about was this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @owenatgov – looking really good so far. I have added quite a few comments but most of them are relatively minor. Very happy to talk through it if that'd be useful.
365f2fb
to
349639a
Compare
Just had a look through, a few more comments...
|
349639a
to
020448c
Compare
I suspect the whitespace issues are caused by the new lines. That can likely be fixed using Nunjucks whitespace control. |
020448c
to
ca83550
Compare
@edwardhorsford was spot on that this was a whitespace issue. All sorted now thanks to Ed's helpful link and some light flexbox styling (thanks again @36degrees). @christopherthomasdesign I believe I've covered all your points. Please take another look at let me know if you spot anything else. I've reorganised the sass so it's a bit more sensible and tidy so some of the comments above will be listed as outdated even though they're still relevant. I'll still work through them in order. |
59a59a2
to
7936cad
Compare
Macro options still need to be 2i'd |
@owenatgov Macro options have passed 2i! Only changes recommended:
|
92cad34
to
1e90e04
Compare
@EoinShaughnessy I've managed to reorder the tables on the website by re-ordering the options in the tech docs in this repo. Tech docs are all sorted! |
CHANGELOG.md
Outdated
|
||
#### Help users navigate through pages with pagination | ||
|
||
You can now use [pagination](https://design-system.service.gov.uk/components/pagination/) to help users navigate forwards and backwards through a series of pages. For example, in search results or guidance that's divided ito multiple website pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linked guidance here doesn't exist yet so this is a broken link, but this is the page it is going to be once it gets published. There's a decision here about if we want to merge this now or once the guidance is deployed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge this in, even with the broken link. While it's unreleased, no one should really be looking at / expect the Changelog to be fully working anyway. When we do the release, it does mean the release notes will contain a broken link for a short period of time until the guidance has been published, but we try to do them in quick succession to limit the length of time this happens. Ideally, most people will become aware of the release via our comms too, which we'll only put out once the guidance has also been published.
TLDR: it's all good to be merged, after v4.1.1 has been released.
db212da
to
4c093dc
Compare
4c093dc
to
9fbf8b9
Compare
9fbf8b9
to
30e9422
Compare
What
Adds the pagination component to govuk-frontend. See below epic for background on this addition .
Related issues/pull requests
Visuals
Standard view
Standard view item hover state
Standard view item focus state
Standard view previous/next link focus state
Standard view current item hover state
Standard small screen view
Standard view with a large number of pages
Teams have the option to hide several page numbers behind ellipses
Without numbers
Alternative "block" view for pre/next navigation without page numbers
Block view hover state
Block view with labels
Block view with labels hover state
Block view with labels focus state