Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw errors during Exit This Page initialisation if key HTML elements are missing #4129

Closed
1 task done
Tracked by #3478
domoscargin opened this issue Aug 24, 2023 · 0 comments · Fixed by #4199
Closed
1 task done
Tracked by #3478

Throw errors during Exit This Page initialisation if key HTML elements are missing #4129

domoscargin opened this issue Aug 24, 2023 · 0 comments · Fixed by #4199
Assignees
@romaricpascal
Labels
exit this page javascript
Milestone
v5.0

Comments

@domoscargin
Copy link
Contributor

domoscargin commented Aug 24, 2023 •
edited by colinrotherham
Loading

What

Update our JavaScript components requiring specific HTML elements to be present so they throw a MissingElementError (extending GOVUKFrontendError) rather than silently fail:

  • The button

Why

This is part of our work to have our components throw rather than silently return during initialisation.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Component has been updated to throw errors
@domoscargin domoscargin added this to the v5.0 milestone Aug 24, 2023
@domoscargin domoscargin moved this from Backlog 🗄 to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Aug 24, 2023
This was referenced Aug 24, 2023
Closed
Closed
@domoscargin domoscargin moved this from Sprint Backlog 🏃🏼‍♀️ to Blocked ⛔ in GOV.UK Design System cycle board Aug 24, 2023
@domoscargin domoscargin moved this from Blocked ⛔ to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Sep 7, 2023
@romaricpascal romaricpascal self-assigned this Sep 11, 2023
@romaricpascal romaricpascal moved this from Sprint Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board Sep 11, 2023
romaricpascal added a commit that referenced this issue Sep 11, 2023
@romaricpascal
Throw MissingElementError when "Exit this page" button is missing
86fccbf 
Wording to match that of the Skip link component, but to be reviewed in [#4072](#4072).
Closes #4129
@romaricpascal romaricpascal mentioned this issue Sep 11, 2023
Merged
romaricpascal added a commit that referenced this issue Sep 11, 2023
@romaricpascal
Throw MissingElementError when "Exit this page" button is missing
e532cb5 
Wording to match that of the Skip link component, but to be reviewed in #4072.

Closes #4129
@romaricpascal romaricpascal moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board Sep 11, 2023
romaricpascal added a commit that referenced this issue Sep 12, 2023
@romaricpascal
Throw ElementError when "Exit this page" button is missing
99f97df 
Closes #4129
romaricpascal added a commit that referenced this issue Sep 18, 2023
@romaricpascal
Throw ElementError when "Exit this page" button is missing
26a179a 
Closes #4129
@romaricpascal romaricpascal moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board Sep 19, 2023
colinrotherham pushed a commit that referenced this issue Sep 27, 2023
@romaricpascal
Throw ElementError when "Exit this page" button is missing
33be879 
Closes #4129
@colinrotherham colinrotherham mentioned this issue Oct 10, 2023
Merged
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romaricpascal romaricpascal

Labels
exit this page javascript
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Throw ElementError when "Exit this page" button is missing alphagov/govuk-frontend
2 participants
@romaricpascal @domoscargin