Code fixes for I18n, Accordion, Character count

As identified by the `tsc` TypeScript compiler
alphagov · Nov 10, 2022 · adcc8a2 · adcc8a2
1 parent f60b999
commit adcc8a2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/src/govuk/components/accordion/accordion.mjs b/src/govuk/components/accordion/accordion.mjs
@@ -37,7 +37,6 @@ var TRANSLATIONS_DEFAULT = {
 function Accordion ($module, config) {
   this.$module = $module
   this.$sections = $module.querySelectorAll('.govuk-accordion__section')
-  this.$showAllButton = ''
   this.browserSupportsSessionStorage = helper.checkForSessionStorage()
 
   var defaultConfig = {

diff --git a/src/govuk/components/character-count/character-count.test.js b/src/govuk/components/character-count/character-count.test.js
@@ -663,7 +663,7 @@ describe('Character count', () => {
 
       await renderAndInitialise(page, 'character-count', {
         nunjucksParams: examples.default,
-        config: {
+        javascriptConfig: {
           // Override maxlength to 10
           maxlength: 10
         },

diff --git a/src/govuk/i18n.mjs b/src/govuk/i18n.mjs
@@ -9,13 +9,11 @@
  * @param {string} config.locale - An overriding locale for the PluralRules functionality.
  */
 export function I18n (translations, config) {
-  config = config || {}
-
   // Make list of translations available throughout function
   this.translations = translations || {}
 
   // The locale to use for PluralRules and NumberFormat
-  this.locale = config.locale || document.documentElement.lang || 'en'
+  this.locale = (config && config.locale) || document.documentElement.lang || 'en'
 }
 
 /**