This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Add new examples for direct attachment rendering #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did attempt to update some of the other examples, but the content changes mean this could cause random test failures wherever we're referencing the content directly. |
benthorner
force-pushed
the
add-featured-attachment-examples
branch
from
5be024c to
7c9c160
Compare
Previously we relied on pre-rendered HTML for the attached 'documents' of publications and consultations. This adds an example to support work to directly render attachments based on metadata in the payload, and an array of featured attachment IDs. See RFC 116 for more details. Note that 'documents' is a required field for publications, so we still need to populate it with an empty array. https://github.com/alphagov/govuk-rfcs/blob/master/rfc-116-store-attachment-data-in-content-items.md
benthorner
force-pushed
the
add-featured-attachment-examples
branch
from
7c9c160 to
3ac9803
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/wM9wqe9H/1587-support-featured-attachments-directly-on-govuk-frontend
Previously we relied on pre-rendered HTML for the attached 'documents'
of publications and consultations. This adds an example to support work
to directly render attachments based on metadata in the payload, and an
array of featured attachment IDs. See RFC 116 for more details.
https://github.com/alphagov/govuk-rfcs/blob/master/rfc-116-store-attachment-data-in-content-items.md