-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove ContentBlock related functionality
Because of a degree of complexity in how Govspeak is rendered in the Publishing Platform, we can’t always fetch embedded content at the point where Govspeak is rendered (this is particuarly the case in Whitehall). With this in mind, and after some discussion with the team, we’ve decided that, for now, it’s better to handle embeds in the Publishing API. With this in mind, rather than letting this functionality die on the vine within Govspeak, we should remove the functionality altogether. As this is pretty new code (and the content modelling team are the only people aware of it and likely to use it), we should remove it from the codebase entirely.
- Loading branch information
Showing
7 changed files
with
1 addition
and
263 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -608,34 +608,6 @@ will output | |
</div> | ||
``` | ||
|
||
### Content blocks | ||
|
||
Authors can embed different types of [supported content](https://github.com/alphagov/govspeak/blob/main/lib/govspeak/content_block.rb#L3) created by the Content Block Manager | ||
|
||
``` | ||
{{embed:content_block_email_address:d308f561-e5ee-45b5-90b2-3ac36a23fad9}} | ||
``` | ||
|
||
with options provided | ||
|
||
``` | ||
{ | ||
content_blocks: [ | ||
{ | ||
content_id: "d308f561-e5ee-45b5-90b2-3ac36a23fad9", | ||
title: "Government Digital Service", | ||
details: { email_address: "[email protected]" }, | ||
} | ||
] | ||
} | ||
``` | ||
|
||
will output | ||
|
||
```html | ||
<span class="embed_content_block_email_address" id="embed_d308f561-e5ee-45b5-90b2-3ac36a23fad9">[email protected]</span> | ||
``` | ||
|
||
### Button | ||
|
||
An accessible way to add button links into content, that can also allow cross domain tracking with [Google Analytics](https://support.google.com/analytics/answer/7372977?hl=en) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.