Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add services frontend #988

Merged
merged 3 commits into from
Jul 26, 2018
Merged

Add services frontend #988

merged 3 commits into from
Jul 26, 2018

Conversation

Vanita Barrett added 3 commits July 24, 2018 09:40
Display the top 3 services in boxes, while showing the next 2 in a document list.
This should follow the same pattern as the topic page tracking
@vanitabarrett vanitabarrett changed the base branch from add-services-ab-2 to master July 24, 2018 15:44
@vanitabarrett vanitabarrett changed the base branch from master to add-services-ab-2 July 24, 2018 15:45
items: taxonomy_navigation[:services][:promoted_content]
} %>

<%= render "govuk_publishing_components/components/document_list", {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the comments from the accessibility review was that the things in the highlight boxes and the document list should all be in one html list. I'm not sure how we'd do that with the existing components. It might be worth us having a chat with the team to see what the best way to resolve this is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to go ahead with this for now as we currently have this problem in a few places (e.g: topic pages) too. I've added a card in the backlog to remind us to revisit the problem, but I'm also not sure how it can work with our existing components as they need to be able to be reused without relying on code being in place. https://trello.com/c/BLsoPJJk/100-spike-can-we-put-highlight-boxes-and-document-list-items-in-one-list

Copy link
Contributor

@sihugh sihugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the accessibility comment. I'm happy to merge this as is (when the previous PR has been merged), and resolve later. This isn't going live yet, so this should be OK

@vanitabarrett vanitabarrett changed the base branch from add-services-ab-2 to master July 26, 2018 08:34
@vanitabarrett vanitabarrett merged commit 94869b3 into master Jul 26, 2018
@vanitabarrett vanitabarrett deleted the add-services-frontend branch July 26, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants