Setup Content Pages Taxonomy Navigation AB Test (with services) #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the AB testing logic we will hook into in subsequent commits. We will be showing taxonomy-based navigation in variant B. Rules for the AB test: - Exclude HTML publications as these don't yet use the universal layout - Included pages must be tagged to at least one live taxon.
Puts in place the supergroup (services) and rummager search logic in place ready to retrieve the most popular services. We are also stubbing the rummager requests in the tests. The test helpers in gds-api-adapters are all set to stub rummager responses. This was done in alphagov/gds-api-adapters@ddae94d as an explicit choice.
Retrieves the most popular services for the first taxon that content item is tagged to. TODO: handle tagging to multiple taxons
This checks that the ab test works for content which is tagged to a single taxon.
Where content is tagged to more than one taxon, get the tagged content for all those taxons. Note that this doesn't put any limit on the number of taxons allowed. We may want to set an arbitrary limit on this just to be on the safe side.
sihugh
approved these changes
Jul 26, 2018
There was a problem hiding this comment.
I'm happy with this. This is behind an AB test which is currently set to 100% on A (that is, to not show any of this stuff).
It will show the new navigation if you're in the B sample and viewing a page tagged to a live taxonomy that is not an HTML publication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/X1RaZyOR/46-get-most-popular-services-content
This PR sets up the Content Pages AB test. The B variant will add taxonomy navigation to the bottom of content pages which are tagged to at least one live taxon (excluding HTML publications).
This PR also includes getting the data for the first supergroup section (Services) in that navigation section. Work done to tidy up the frontend rendering of this section will be done in a later commit.
Example tagged to one taxon
Example tagged to multiple taxons
Note: we are currently rendering all results in highlight boxes rather than making use of the document list component. This will be addressed in a later commit.
Examples:
You will need to have an extension like ModHeader installed in your browser to see the B Variant. The values should be:
Request Header Name: GOVUK-ABTest-ContentPagesNav
Request Header Value: B
Component guide for this PR:
https://government-frontend-pr-983.herokuapp.com/component-guide