Switch from PhantomJS to Chrome #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhantomJS development has now been abandoned and there are some outstanding bugs that will not be fixed. See https://docs.publishing.service.gov.uk/manual/migrate-testing-from-phantomjs-to-selenium-chrome.html
Using Chrome instead of PhantomJS means cache headers are being correctly observed. A number of test cases share the same content item fixture, but make changes to the body of the content item for the specific test case. We therefore need to add a cachebust string to the URL as the content item base path remains the same.
Using Chrome instead of PhantomJS means that whitespace is interpreted differently. Our assertions ignore things like new line breaks which are returned by Capybara.
Using Chrome instead of PhantomJS means we can no longer manipulate the browser by executing a script on the page. This is not something a user would typically do therefore Selenium prevents it.
Using Chrome instead of PhantomJS means we can no access the status code. This is not something a user would typically do therefore Selenium prevents it. Instead we look for a `govuk-content-id` meta tag with the correct content attribute that will be rendered if the page is successfully rendered.
Using Chrome instead of PhantomJS means we can no do this. This isn’t part of user acceptance so I’ve removed the assertion.
Requesting the atom feed through Chrome gives us a HTML response. Instead we make a direct request and parse it using Ruby’s RSS library.
sihugh
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhantomJS development has now been abandoned and there are some outstanding bugs that will not be fixed.
Contains various fixes that ensure the test suite is compatible with the behaviour of Chrome.
https://trello.com/c/zrQWOwDl
Visual regression results:
https://government-frontend-pr-975.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-975.herokuapp.com/component-guide