Stop using components from Static #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 9.2.3 to 9.3.0. - [Release notes](https://github.com/alphagov/govuk_publishing_components/releases) - [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/master/CHANGELOG.md) - [Commits](alphagov/govuk_publishing_components@v9.2.3...v9.3.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [slimmer](https://github.com/alphagov/slimmer) from 12.1.0 to 13.0.0. - [Release notes](https://github.com/alphagov/slimmer/releases) - [Changelog](https://github.com/alphagov/slimmer/blob/master/CHANGELOG.md) - [Commits](alphagov/slimmer@v12.1.0...v13.0.0) Signed-off-by: dependabot[bot] <[email protected]>
We moved to using the component from the gem in #929, but didn't updated the tests. They kept working because they check the absence of a class.
This somehow kept working after we started using the govspeak component from the gem.
This doesn't work anymore after we've moved this app to use the component from the gem.
This test is checking for the summary, but had to do a backflip to get around the component. We no longer need to do that.
thomasleese
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make the app use the metadata component from the gem, and cleans up all other usage of Static-based components. See commits for details.
https://trello.com/c/pU7YINt1