Use organisation logo component from gem #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
use-organisation-logo-component-from-gem
branch
from
dd8efe2 to
b921222
Compare
- an intermittent error is occurring with tests visiting random HTML publications, this may be because there are no organisation logos to display on them?
andysellick
force-pushed
the
use-organisation-logo-component-from-gem
branch
from
b921222 to
cb10480
Compare
tijmenb
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the organisation logo component added to the gem (alphagov/govuk_publishing_components#365), replacing it with the one from static.
Trello card: https://trello.com/c/jcRtJtvm/32-move-the-organisation-logo-component-to-the-gem
Trello card: https://trello.com/c/EKEwjJ7u/167-modify-component-organisation-logo
Visual regression results:
https://government-frontend-pr-931.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-931.herokuapp.com/component-guide