Remove notice component #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
remove-notice-component
branch
from
1cbb48b to
d9c8953
Compare
andysellick
changed the title
andysellick
force-pushed
the
remove-notice-component
branch
from
d9c8953 to
8be9b69
Compare
andysellick
force-pushed
the
remove-notice-component
branch
from
8be9b69 to
7cc0063
Compare
andysellick
force-pushed
the
remove-notice-component
branch
from
71f0212 to
d9ebaca
Compare
- update assert_has_component_govspeak to be simpler, since the component is no longer coming from static in a strange format - remove within_component_govspeak method from test helper as no longer needed - update all tests that relied on these methods - amend some tests that were too specific and failing
- since it's now just has_text, no need for it to be a separate method - update tests
andysellick
force-pushed
the
remove-notice-component
branch
from
d9ebaca to
3cafef2
Compare
tijmenb
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove notice component and update to use same component now in gem.
Trello card: https://trello.com/c/vdIdfjHn/121-modify-component-notice
Visual regression results:
https://government-frontend-pr-916.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-916.herokuapp.com/component-guide