Remove contents list component #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
changed the title
andysellick
force-pushed
the
remove-contents-list-component
branch
from
a4e5d85 to
25f5f1f
Compare
andysellick
changed the title
- update contents list with body component and other references to use contents list component from gem - update tests
andysellick
force-pushed
the
remove-contents-list-component
branch
from
7b2be98 to
396acd2
Compare
tijmenb
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contents list component has been moved to the gem. This PR updates government-frontend to use the component there, and remove it from here.
Trello card: https://trello.com/c/aDQ8nEKO/90-modify-component-contents-list
Visual regression results:
https://government-frontend-pr-915.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-915.herokuapp.com/component-guide