Add last_updated timestamp on help_page format #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
approved these changes
May 17, 2018
| @@ -16,7 +16,7 @@ | |||
| rich_govspeak: true %> | |||
|
|
|||
| <% #https://github.com/alphagov/government-frontend/pull/329#issuecomment-297681738 %> | |||
There was a problem hiding this comment.
I reckon we can remove this comment now.
deborahchua
force-pushed
the
enable-timestamp-on-help-page-format
branch
from
ecbd107 to
79f26dd
Compare
|
Thanks @thomasleese! I've updated that now 👍 |
thomasleese
approved these changes
May 17, 2018
To ensure we are GDPR compliant we need to follow the privacy notice template where we have to include an updated timestamp on the page. The `last_updated` uses the `public_updated_at` content_item attribute.
deborahchua
force-pushed
the
enable-timestamp-on-help-page-format
branch
from
79f26dd to
49cd505
Compare
vanitabarrett
suggested changes
May 17, 2018
There was a problem hiding this comment.
Can we make use of this component so this stays consistent with other document types rendered by government-frontend? https://government-frontend.herokuapp.com/component-guide/published-dates/just_last_updated_date
For consistency we should be using the frontend component that renders the last_updated attribute.
vanitabarrett
approved these changes
May 17, 2018
|
Thanks @vanitabarrett! |
thomasleese
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we are GDPR compliant we need to follow the privacy notice template where we have to include an updated timestamp on the privacy page (https://www.gov.uk/help/privacy-policy), which uses the
help_pagedocument type.The
last_updateduses thepublic_updated_atcontent_item attribute and will affect allhelp_pagepages.Trello card:
Enable the 'last updated' timestamp on GOV.UK privacy page / 'help_page' format
https://government-frontend-pr-907.herokuapp.com/help/privacy-policy
Visual regression results:
https://government-frontend-pr-907.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-907.herokuapp.com/component-guide