Update share links component usage #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
changed the title
- now in gem
- component title now defaults to none, add correct titles to share links options
andysellick
force-pushed
the
update-share-links-component-usage
branch
from
8bc9d42 to
6d4c5f0
Compare
andysellick
changed the title
tijmenb
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update this app to use the share links component from the gem, and update as the component has changed.
This PR cannot be merged until this PR is merged and deployed as a new version of the gem (done).
https://government-frontend-pr-906.surge.sh/gallery.html
https://government-frontend-pr-906.herokuapp.com/component-guide