Add schema.org data via the new component #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tijmenb
force-pushed
the
use-component-structured-data
branch
from
a51d61c to
b2572cf
Compare
tijmenb
changed the title
sihugh
reviewed
May 17, 2018
| <%= render 'govuk_publishing_components/components/machine_readable_metadata', | ||
| schema: :article, | ||
| content_item: @content_item.content_item, | ||
| canonical_url: @content_item.canonical_url %> |
There was a problem hiding this comment.
do we need canonical_url for answers?
There was a problem hiding this comment.
Good point - removed.
This uses the new component built in alphagov/govuk_publishing_components#318. https://trello.com/c/RLQI1IUV
tijmenb
force-pushed
the
use-component-structured-data
branch
from
b2572cf to
be4ed0f
Compare
sihugh
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the app use the new "Machine readable metadata" component built in alphagov/govuk_publishing_components#318. This means more news articles will have schema.org structured data, as the component will output the data even if there's no image or author present (something that Google requires, but isn't actually required).
See the validation for News articles (they had it before)
It also adds the schemas to more formats:
These formats were chosen before they appear in the top 500 of mainstream content. The agency that helps us with SEO has taken a snapshot of these to see if the schemas have an influence on the Google Answer Boxes.
I'm assuming that more formats will follow.
https://trello.com/c/RLQI1IUV